Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

Subject: fix typos

Feature or Bugfix

  • Bugfix

@picnixz picnixz added the i18n label Oct 25, 2023
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (still you'll need to wait for Adam's approval).

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the codespell branch 4 times, most recently from 90da3e4 to 8aed5e5 Compare December 31, 2023 16:44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the .po files can be excluded from the spelling checker, they're automatically updated from the source.

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Dec 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought, but I had been told otherwise in #11735 (comment).

Any way, these updates are in a separate commit, they would be easy to discard.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change a localized string, I think what is autogenerated is an empty translation, hence we probably need to manually update translations in this case but I may be wrong.

"""
if cell.row is None or cell.col is None:
msg = 'Cell co-ordinates have not been set'
msg = 'Cell coordinates have not been set'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

co-ordinates is fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both co-ordinate and coordinate are fine, especially in British English according to dictionaries. However, the Google Ngram Viewer shows coordinate in wider use, including in the British English corpus strangely enough.

It's up to you, but what's wrong with following common use when targetting a large and international audience?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though co-ordinate is fine, I personally prefer one without "-". Also it removes one character from the code base so it's technically an optimization!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a compromise and use "coördinates" like the New Yorker! 🙃

https://www.newyorker.com/culture/culture-desk/the-curse-of-the-diaeresis

@AA-Turner AA-Turner merged commit 460a630 into sphinx-doc:master Jan 4, 2024
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch January 4, 2024 06:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants